W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > June 2017

Re: [webrtc-pc] Don't update state if setLocalD is called with bogus input

From: Bernard Aboba via GitHub <sysbot+gh@w3.org>
Date: Sun, 11 Jun 2017 21:53:47 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-307659428-1497218026-sysbot+gh@w3.org>
@stefak I don't believe that the intent is to change the state.  However, the text makes it sounds like `lastOffer` and `lastAnswer` are variables which are set as a result of calling setLocalDescription regardless of whether the input is bogus or not.  This is not the case - both `lastOffer` and `lastAnswer` represent internal slots set by `createOffer` and `createAnswer`, respectively.  

Related: Issues https://github.com/w3c/webrtc-pc/issues/1309 and https://github.com/w3c/webrtc-pc/issues/1330 .

-- 
GitHub Notification of comment by aboba
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1344#issuecomment-307659428 using your GitHub account
Received on Sunday, 11 June 2017 21:53:54 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 4 June 2019 15:32:44 UTC