W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > June 2017

Re: [webrtc-pc] setLocalDescription algorithm for rejecting modification

From: Bernard Aboba via GitHub <sysbot+gh@w3.org>
Date: Mon, 05 Jun 2017 17:59:56 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-306258836-1496685594-sysbot+gh@w3.org>
@fippo Agree that InvalidModificationError can no longer happen in "set an RTCSessionDescription". 
Also, since description.sdp can now be null it appears that the steps in "set an RTCSessionDescription" could result in an "sdp-syntax-error" even when SLD is called correctly. 

In JSEP Section 5.5, the check against the last call to createOffer/createAnswer is done after checking the type against the current state (e.g. after Step 3 in "set an RTCSessionDescription").  So I would propose the following:

a. Delete Step 2 in "set an RTCSessionDescription". 
b. Move steps 6 and 7 in SLD to after the new step 2 in "set an RTCSessionDescription"
c. Change step 8 in SLD to "Return the result of setting the RTCSessionDescription indicated by the (potentially modified) description."

-- 
GitHub Notification of comment by aboba
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1330#issuecomment-306258836 using your GitHub account
Received on Monday, 5 June 2017 18:00:02 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 4 June 2019 15:32:43 UTC