W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > July 2017

Re: [webrtc-pc] Don't fire ONN on removeTrack() if sender.track is already null.

From: jan-ivar via GitHub <sysbot+gh@w3.org>
Date: Mon, 31 Jul 2017 17:50:31 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-319144074-1501523428-sysbot+gh@w3.org>
Hi, I'm back from a week off. This is unrelated to https://github.com/w3c/webrtc-pc/issues/1390. Sorry for the delay in answering and not filing a separate issue, as I thought it trivial (I was wrong)! 

First, I believe @fippo meant to write:
```js
pc.removeTrack(someSender);
pc.removeTrack(someSender);
```
I think he and I were confused by [current behavior](https://jsfiddle.net/jib1/ucvgcaox/) where the above fires ONN 3 (instead of 2!) times in Chrome (and fails for unrelated reasons in Firefox).

But @taylor-b is right, the [[[needNegotiation](http://w3c.github.io/webrtc-pc/#dfn-update-the-negotiation-needed-flag)]] internal slot already catches this; doesn't fire twice, so the spec was already fine here wrt ONN.

The remaining issue would be the implicit setting of direction. What should the following output?
```js
pc.removeTrack(transceiver.sender);
transceiver.setDirection("sendrecv");
pc.removeTrack(transceiver.sender);
console.log(transceiver.direction); // "recvonly" or "sendrecv" ?
```

-- 
GitHub Notification of comment by jan-ivar
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/1434#issuecomment-319144074 using your GitHub account
Received on Monday, 31 July 2017 17:51:00 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:21:40 UTC