W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > July 2017

Re: [webrtc-pc] transactionId validation for get/set parameters should have more consistent definition

From: Soares Chen via GitHub <sysbot+gh@w3.org>
Date: Mon, 17 Jul 2017 06:37:10 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-315677387-1500273429-sysbot+gh@w3.org>
The transactionId validation should also take into account of async race conditions and make sure that sequence of synchronous calls to get/set parameters has well defined behavior. e.g.:

```javascript
const param = sender.getParameters();
const promise = sender.setParameters(param);
sender.getParameters();

promise.then(...); // resolve or reject?
```

Also note that the validation of `parameters.encodings` and any other fields should not have to rely on `sender.getParameters()`, as that would result in new transaction ID being generated and make the following transactionId validation behavior undefined.

-- 
GitHub Notification of comment by soareschen
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/issues/1488#issuecomment-315677387 using your GitHub account
Received on Monday, 17 July 2017 06:37:16 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:21:40 UTC