W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > January 2017

Re: [webrtc-pc] Changing "non-null" to "missing" to match IDL terminology.

From: stefan hakansson via GitHub <sysbot+gh@w3.org>
Date: Thu, 19 Jan 2017 14:26:30 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-273789400-1484835988-sysbot+gh@w3.org>
I had exactly the same thought as @alvestrand.

On Thu, Jan 19, 2017 at 2:25 PM, Harald Alvestrand 
<notifications@github.com
> wrote:

> *@alvestrand* commented on this pull request.
> ------------------------------
>
> In webrtc.html
> 
<https://github.com/w3c/webrtc-pc/pull/994#pullrequestreview-17453099>:
>
> > @@ -1807,8 +1807,8 @@
>                          </ol>
>                        </li>
>                        <li>
> -                        <p>If 
<code><var>candidate</var>.ufrag</code> is
> -                        non-null, and is not equal to any ufrag 
present in the
> +                        <p>If 
<code><var>candidate</var>.ufrag</code> is not
> +                        missing, and is not equal to any ufrag 
present in the
>
> My hatred of double negatives is coming out. Can we say "present" 
instead
> of "not missing"?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> 
<https://github.com/w3c/webrtc-pc/pull/994#pullrequestreview-17453099>,
> or mute the thread
> 
<https://github.com/notifications/unsubscribe-auth/ABICrlIu44x2CzzZBfZAvvUCPqSqkrgPks5rT2RcgaJpZM4LjHbz>
> .
>


-- 
GitHub Notification of comment by stefhak
Please view or discuss this issue at 
https://github.com/w3c/webrtc-pc/pull/994#issuecomment-273789400 using
 your GitHub account
Received on Thursday, 19 January 2017 14:26:36 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 4 June 2019 15:32:41 UTC