W3C home > Mailing lists > Public > public-webrtc-logs@w3.org > April 2017

Re: [webrtc-pc] Split getContributingSources into two methods, for CSRCs and SSRCs.

From: Taylor Brandstetter via GitHub <sysbot+gh@w3.org>
Date: Thu, 20 Apr 2017 06:03:58 +0000
To: public-webrtc-logs@w3.org
Message-ID: <issue_comment.created-295592368-1492668236-sysbot+gh@w3.org>
I liked Harald's suggestion to just call it `getSsrcs`, but that seemed inconsistent with `getContributingSources` (which could just as easily be `getCsrcs`).

Another naming thing I don't like is that the CSRC or SSRC identifier is called `source`, as opposed to just `ssrc`/`csrc`, or even `identifier`. Is it too late to change this?

Naming gripes aside, I don't think there are any real issues with this.

GitHub Notification of comment by taylor-b
Please view or discuss this issue at https://github.com/w3c/webrtc-pc/pull/1133#issuecomment-295592368 using your GitHub account
Received on Thursday, 20 April 2017 06:04:09 UTC

This archive was generated by hypermail 2.4.0 : Saturday, 6 May 2023 21:19:40 UTC