- From: Dan Burnett <dburnett@voxeo.com>
- Date: Wed, 1 Jul 2015 21:31:05 -0400
- To: Harald Alvestrand <harald@alvestrand.no>
- Cc: WebRTC-Editors <webrtc-editors@alvestrand.no>
Harald, We had decided to merge in gUM PR #194 (overconstrainederror) after the dated draft push, and the merge needs to be done manually. In attempting to do so, I noticed that the entire Constraint Failure step that uses it had disappeared at some point between when I wrote the PR and now. After some sleuthing, it appears that it was removed by Adam in commit 7cd4336 because it *was no longer referenced*. After significantly more sleuthing, it appears that your constraint algorithm rewrite (commit 4c8c7c2) is when Constraint Failure became a NotFoundError. When required constraints cannot be satisfied, either in the gUM call or in applyConstraints() (or as an event), I believe we should be returning an OverconstrainedError as has been discussed all along. Harald, did you intend to change to a NotFoundError, was this a typo, or am I missing something that explains this? -- dan
Received on Thursday, 2 July 2015 01:39:20 UTC