Re: [w3c/web-based-payment-handler] Allow web-based payment handlers to report back internal error (PR #429)

@romandev commented on this pull request.

looks great

> 

I noticed that the `details` validation step doesn't pass an `OperationError` `DOMException` to the payment app failure algorithm, while the other validation steps (e.g., `methodName`, `shippingAddress`, `payerName`, etc.) all do.

Was this intentional, or just accidentally missed? Let me know if there's a reason for treating it differently — I might be missing some context.

> @@ -1737,6 +1734,39 @@ <h2>
           reconciliation after network or other failures.
         </p>
       </section>
+      <section>
+        <h2>
+          <dfn>Payment App Failure Algorithm</dfn>
+        </h2>
+        <p>
+          When this algorithm is invoked with |reason|, the user agent MUST run
+          the following steps:
+        </p>
+        <ol class="algorithm">
+          <li>
+            If |reason| is an {{"OperationError"}} {{DOMException}}, then run
+     the <a>Payment handler indicates an internal error algorithm</a> as

nit: Might need a `data-cite` import here? The link doesn't seem to resolve in the preview.

> +      <section>
+        <h2>
+          <dfn>Payment App Failure Algorithm</dfn>
+        </h2>
+        <p>
+          When this algorithm is invoked with |reason|, the user agent MUST run
+          the following steps:
+        </p>
+        <ol class="algorithm">
+          <li>
+            If |reason| is an {{"OperationError"}} {{DOMException}}, then run
+     the <a>Payment handler indicates an internal error algorithm</a> as
+            defined in [[!payment-request]].
+          </li>
+          <li>
+            Otherwise, run the <a>user aborts the payment request algorithm</a>

ditto

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/web-based-payment-handler/pull/429#pullrequestreview-3892659495
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/web-based-payment-handler/pull/429/review/3892659495@github.com>