Re: [w3c/payment-request] fix: use InvalidStateError for non-fully-active document checks (PR #1056)

@stephenmcgruer approved this pull request.



> @@ -1331,9 +1331,17 @@ <h2>
             <ol>
               <li>Close down the user interface.
               </li>
+              <li>Set |request|.{{PaymentRequest/[[state]]}} to

Side-thought - should we capture the various repeated steps for "shutting down" payment request into their own steps somewhere, so we don't have to keep repeating and missing ones? Something like:

Steps to quit out of payment handler due to error:
  - Set state to closed
  - Set is-showing to false
  - Queue a task to reject (relevant promise) with the passed-in error type

I haven't actually verified if the steps are similar enough for this to be worth it rather than being restricting, just a thought :)


-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/1056#pullrequestreview-3883727018
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/payment-request/pull/1056/review/3883727018@github.com>