Re: [w3c/payment-handler] Remove PaymentInstruments API (PR #409)

@stephenmcgruer approved this pull request.



> @@ -97,9 +97,8 @@ <h2>
         <li>A payment request event type {{PaymentRequestEvent}}). A <a>payment

```suggestion
        <li>A payment request event type ({{PaymentRequestEvent}}). A <a>payment
```

Nit, while you're here :).

(or alternatively, `A payment request event type, {{PaymentRequestEvent}}.` No closing `)`)

> @@ -97,9 +97,8 @@ <h2>
         <li>A payment request event type {{PaymentRequestEvent}}). A <a>payment
         handler</a> is an event handler for the {{PaymentRequestEvent}}.
         </li>
-        <li>An extension to the service worker registration interface
-        ({{PaymentManager}} to manage the definition, display, and user
-        selection of {{PaymentInstrument}}s.
+        <li>An extension to the <a>service worker registration</a> interface
+        ({{PaymentManager}} to manage properties of payment handlers.

```suggestion
        ({{PaymentManager}}) to manage properties of payment handlers.
```

Or alternatively, remove the leading `(` and add commas instead

>          </li>
-        <li>When the user (the payer) selects an <a data-lt=
-        "PaymentManager.instruments">instrument</a>, the user agent fires a
-        {{PaymentRequestEvent}} (cf. the <a>user interaction task source</a>)
-        in the service worker whose <a data-lt=
-        "ServiceWorkerRegistration.paymentManager">PaymentManager</a> the
-        instrument was registered with. The {{PaymentRequestEvent}} includes
+        <li>When the <a>payer</a> user selects a payment handler, the user agent
+        fires a {{PaymentRequestEvent}} (cf. the <a>user interaction task
+        source</a>) in its service worker. The {{PaymentRequestEvent}} includes

Nit; `its` is ambiguous here (refers to either the payment handler or to the user agent). Needs to be: `in the service worker for the selected payment handler` or similar

> @@ -289,15 +246,14 @@ <h2>
         </figure>
       </section>
     </section>
+    </section>

Double-close here? Or are the indentation levels wrong?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/pull/409#pullrequestreview-1269454231
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/payment-handler/pull/409/review/1269454231@github.com>