- From: Stephen McGruer <notifications@github.com>
- Date: Wed, 06 Jul 2022 07:04:06 -0700
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 6 July 2022 14:04:19 UTC
@stephenmcgruer approved this pull request. LGTM (and @rsolomakhin ) I personally am a fan of having defined concepts rather than prose where possible (e.g., I don't like "an IDL value of the type specified by the specification"), but I acknowledge (a) that that may just be my opinion and (b) that at least for now no public specification exists that will link to this. Putting on my Chrome hat, I believe we'll be happy to make the IDL change in our implementation though we will likely not do anything with the passed data. Updating the WPT tests would be great! :) -- Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-request/pull/982#pullrequestreview-1030157176 You are receiving this because you are subscribed to this thread. Message ID: <w3c/payment-request/pull/982/review/1030157176@github.com>
Received on Wednesday, 6 July 2022 14:04:19 UTC