Re: [w3c/payment-request] Add dir and lang support for human readable labels (#971)

@aphillips approved this pull request.

I think this covers the need to call out a potential change while we figure out whether to make it and what form it should take.

> @@ -1706,6 +1711,16 @@ <h2>
       <h2>
         <dfn>PaymentItem</dfn> dictionary
       </h2>
+      <aside class="addition" id="a1">
+        <p>
+        <span class="marker">Candidate Addition 1:</span>
+         This dictionary might include definitions for optional members `lang` and
+        `dir` to indicate the language and text-direction override of {{PaymentItem/label}}. 

It wouldn't be "text-direction override". It would be better to say "base direction" or "base text-direction". 

> @@ -1945,6 +1960,16 @@ <h2>
           <h3>
             <dfn>PaymentValidationErrors</dfn> dictionary
           </h3>
+
+          <aside class="addition" id="a2">
+           <p><span class="marker">Candidate Addition 1:</span>
+           This dictionary might include definitions for optional members `lang` and
+           `dir` to indicate the language and text-direction override of {{PaymentValidationErrors/error}}. 

same comment as above.

> @@ -1706,6 +1711,16 @@ <h2>
       <h2>
         <dfn>PaymentItem</dfn> dictionary
       </h2>
+      <aside class="addition" id="a1">
+        <p>
+        <span class="marker">Candidate Addition 1:</span>
+         This dictionary might include definitions for optional members `lang` and

we generally prefer `language` and `direction` for data values and `lang` and `dir` for attribute values, but changing that would be optional, as there is a certain harmony to using the same names as the HTML attributes. I'd just leave it for now.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/971#pullrequestreview-774327085