- From: Marcos Cáceres <notifications@github.com>
- Date: Tue, 23 Nov 2021 00:20:14 -0800
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 23 November 2021 08:20:27 UTC
@marcoscaceres commented on this pull request.
> @@ -155,6 +155,15 @@ <h2>
for payment. Concretely, a payment handler defines:
</p>
<dl>
+ <dt>
+ <dfn>Steps to convert and validate payment method data</dfn>
+ </dt>
+ <dd>
+ How a <a>payment method</a> [=converted to an IDL value|converts=] and
Hmm... yeah, that algorithm (2) seems to overstep a bit... it's doing checking, but it's also mutating an object. Editorially, I'd recommend splitting that (personally, that's come back to bite me quite a few times).
Nevertheless, I get what you are trying to do now... but I'd still urge your to split those into two if possible.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/977#discussion_r754881483
Received on Tuesday, 23 November 2021 08:20:27 UTC