- From: Janice Shiu <notifications@github.com>
- Date: Mon, 27 Jan 2020 23:23:10 -0800
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/payment-request/pull/896/review/349148408@github.com>
janiceshiu requested changes on this pull request.
would be lovely to get some things clarified. also suggested some rewordings to make the text clearer ^^
> @@ -1089,12 +1089,23 @@ <h2>
</li>
</ol>
</li>
- <li>Present a user interface that will allow the user to interact
- with the |handlers|. The user agent SHOULD prioritize the preference
- of the user when presenting payment methods. It is RECOMMENDED that
- the language of the user interface match the [=node/language=] of the
- <a data-cite="HTML/dom.html#the-body-element-2">the body element</a>
- element.
+ <li>
+ <p>
+ Present a user interface that will allow the user to interact
+ with the |handlers|. The user agent SHOULD prioritize the
+ preference of the user when presenting payment methods.
```suggestion
user's preference when presenting payment methods.
```
* clearer and shorter wording
* also - it is not very clear to me what `preferences` users are allowed to have. could you clarify this?
> @@ -1089,12 +1089,23 @@ <h2>
</li>
</ol>
</li>
- <li>Present a user interface that will allow the user to interact
- with the |handlers|. The user agent SHOULD prioritize the preference
- of the user when presenting payment methods. It is RECOMMENDED that
- the language of the user interface match the [=node/language=] of the
- <a data-cite="HTML/dom.html#the-body-element-2">the body element</a>
- element.
+ <li>
+ <p>
+ Present a user interface that will allow the user to interact
+ with the |handlers|. The user agent SHOULD prioritize the
+ preference of the user when presenting payment methods.
+ </p>
+ <aside class="note" title="Localization of the payment sheet">
+ <p>
+ The API does not provide a means for developers to specify the
```suggestion
The API does not provide a way for developers to specify the
```
imho `way` is less jargon-y than `means`
> + language in which the payment sheet is presented to end
+ users. As such, user agents will generally present the payment
read through the [show method](https://www.w3.org/TR/payment-request/#show-method). after doing a quick search in that section, I noticed that with one exception, the term `user` is always used. that exception is for `end-user` and it appears here.
https://github.com/w3c/payment-request/blob/fe208dba28724d0a316bf706fbf39cc4414bd8f2/index.html#L1119-L1120
elsewhere in the spec, `end user` is occasionally used.
it is not clear to me what is the difference between a `user` and an `end user`. I did not see linked definitions for `user`, `end-user`, or `end user`. there is, however, a definition for `user agent`.
perhaps we could clarify the difference between a `user` and an `end user`, and decide whether to use `end user` or `end-user`?
> + sheet using the user agent's default language. The working
+ group is contemplating adding the ability for developers to
+ specify the language the payment sheet, and of specific
+ {{PaymentItems}}, in a future version of this API.
```suggestion
The working group is thinking of adding the ability for developers to specify the language for the payment sheet and for specific {{PaymentItems}}. If added, these abilities will be in a future version of this API.
```
* Overall, this is a bit hard to read and understand. I had to read it multiple times. Thus, to make the meaning clearer, I split it into 2 sentences.
* `contemplating adding` is a rather hard to read and understand. probably due to the two successive `-ing` verbs.
> - with the |handlers|. The user agent SHOULD prioritize the preference
- of the user when presenting payment methods. It is RECOMMENDED that
- the language of the user interface match the [=node/language=] of the
- <a data-cite="HTML/dom.html#the-body-element-2">the body element</a>
- element.
+ <li>
+ <p>
+ Present a user interface that will allow the user to interact
+ with the |handlers|. The user agent SHOULD prioritize the
+ preference of the user when presenting payment methods.
+ </p>
+ <aside class="note" title="Localization of the payment sheet">
+ <p>
+ The API does not provide a means for developers to specify the
+ language in which the payment sheet is presented to end
+ users. As such, user agents will generally present the payment
```suggestion
users. As such, user agents will generally use the user agent's default language to present the payment sheet.
```
* Sentence was rather hard to read. Have suggested a rewording.
* `generally` doesn't seem to have a particular meaning unlike `SHOULD` and `RECOMMENDED`. In this case, it is not clear how strictly the spec wants user agents to follow the `generally` recommendation. Perhaps we could clarify this?
> - <a data-cite="HTML/dom.html#the-body-element-2">the body element</a>
- element.
+ <li>
+ <p>
+ Present a user interface that will allow the user to interact
+ with the |handlers|. The user agent SHOULD prioritize the
+ preference of the user when presenting payment methods.
+ </p>
+ <aside class="note" title="Localization of the payment sheet">
+ <p>
+ The API does not provide a means for developers to specify the
+ language in which the payment sheet is presented to end
+ users. As such, user agents will generally present the payment
+ sheet using the user agent's default language. The working
+ group is contemplating adding the ability for developers to
+ specify the language the payment sheet, and of specific
```suggestion
specify the language of the payment sheet, and of specific
```
Missing a word. ^^ I've also suggested a rewording of the entire sentence in another comment.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/896#pullrequestreview-349148408
Received on Tuesday, 28 January 2020 07:23:14 UTC