Re: [w3c/payment-handler] Add a privacy consideration note for issue #330. (#331)

ianbjacobs commented on this pull request.

Thanks, Danyao! I have made some minor editorial suggestions. I used the new GitHub tool (shown to me by Marcos) so if you are happy with the changes you can easily incorporate them.

> @@ -2235,7 +2235,10 @@ <h2>
           <li>The <a>CanMakePaymentEvent</a> event should not be fired in
           private browsing mode. The user agent should behave as if
             <a data-lt="CanMakePaymentEvent.respondWith()">respondWith()</a>
-            was called with <code>true</code>.
+            was called with <code>false</code>. We acknowledge a consequent
+            risk: if a merchant controls both the origin of the Payment Request

```suggestion
            risk: if an entity controls both the origin of the Payment Request
```

> @@ -2235,7 +2235,10 @@ <h2>
           <li>The <a>CanMakePaymentEvent</a> event should not be fired in
           private browsing mode. The user agent should behave as if
             <a data-lt="CanMakePaymentEvent.respondWith()">respondWith()</a>
-            was called with <code>true</code>.
+            was called with <code>false</code>. We acknowledge a consequent
+            risk: if a merchant controls both the origin of the Payment Request
+            API call and the payment handler, it is possible to deduce from the

```suggestion
            API call and the origin of the payment handler, that entity may be able to deduce
```

> @@ -2235,7 +2235,10 @@ <h2>
           <li>The <a>CanMakePaymentEvent</a> event should not be fired in
           private browsing mode. The user agent should behave as if
             <a data-lt="CanMakePaymentEvent.respondWith()">respondWith()</a>
-            was called with <code>true</code>.
+            was called with <code>false</code>. We acknowledge a consequent
+            risk: if a merchant controls both the origin of the Payment Request
+            API call and the payment handler, it is possible to deduce from the
+            result that the user may be in private browsing mode.

```suggestion
            that the user may be in private browsing mode.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/pull/331#pullrequestreview-197839892