Re: [w3c/payment-handler] Removed conflicts from Jake Archibald pull request (#327)

rsolomakhin commented on this pull request.

Almost missed this :-)

The field names in `canmakepayment` event should be associated with `CanMakePaymentEvent`, not the `PaymentRequestEvent`.

> -              </li>
-              <li>Dispatch <var>e</var> to <var>global</var>.
-              </li>
-              <li>Wait for all of the promises in the <a>extend lifetime
-              promises</a> of <var>e</var> to resolve.
-              </li>
-            </ol>
+          <li>
+            <p>
+              <a>Fire Functional Event</a> "<code>canmakepayment</code>" using
+              <a>CanMakePaymentEvent</a> on <var>registration</var> with the
+              following properties:
+            </p>
+            <dl>
+              <dt>
+                <a data-lt="PaymentRequestEvent.topOrigin">topOrigin</a>

```suggestion
                <a data-lt="CanMakePaymentEvent.topOrigin">topOrigin</a>
```

> +              <a>Fire Functional Event</a> "<code>canmakepayment</code>" using
+              <a>CanMakePaymentEvent</a> on <var>registration</var> with the
+              following properties:
+            </p>
+            <dl>
+              <dt>
+                <a data-lt="PaymentRequestEvent.topOrigin">topOrigin</a>
+              </dt>
+              <dd>
+                <a data-cite="!HTML#ascii-serialisation-of-an-origin">the
+                serialization of the origin</a> of the top level payee web
+                page.
+              </dd>
+              <dt>
+                <a data-lt=
+                "PaymentRequestEvent.paymentRequestOrigin">paymentRequestOrigin</a>

```suggestion
                "CanMakePaymentEvent.paymentRequestOrigin">paymentRequestOrigin</a>
```

> +              <dd>
+                <a data-cite="!HTML#ascii-serialisation-of-an-origin">the
+                serialization of the origin</a> of the top level payee web
+                page.
+              </dd>
+              <dt>
+                <a data-lt=
+                "PaymentRequestEvent.paymentRequestOrigin">paymentRequestOrigin</a>
+              </dt>
+              <dd>
+                <a data-cite="!HTML#ascii-serialisation-of-an-origin">the
+                serialization of the origin</a> of the context where
+                PaymentRequest was initialized.
+              </dd>
+              <dt>
+                <a data-lt="PaymentRequestEvent.methodData">methodData</a>

```suggestion
                <a data-lt="CanMakePaymentEvent.methodData">methodData</a>
```

> +                "PaymentRequestEvent.paymentRequestId">paymentRequestId</a>
+              </dt>
+              <dd>
+                The [[\details]].<a>id</a> from the <a>PaymentRequest</a>.
+              </dd>
+              <dt>
+                <a data-lt=
+                "PaymentRequestEvent.instrumentKey">instrumentKey</a>
+              </dt>
+              <dd>
+                The <a>instrumentKey</a> of the selected
+                <a>PaymentInstrument</a>, or the empty string if none was
+                selected.
+              </dd>
+              <dt>
+                <a data-lt="PaymentRequestEvent.modifiers">modifiers</a>

```suggestion
                <a data-lt="CanMakePaymentEvent.modifiers">modifiers</a>
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/pull/327#pullrequestreview-165734914