Re: [w3c/payment-handler] Removed conflicts from Jake Archibald pull request (#327)

rsolomakhin commented on this pull request.

Looks good, but need to preserve the fields in `PaymentRequestEvent`.

> +              <dt>
+                <a data-lt=
+                "PaymentRequestEvent.paymentRequestOrigin">paymentRequestOrigin</a>
+              </dt>
+              <dd>
+                <a data-cite="!HTML#ascii-serialisation-of-an-origin">the
+                serialization of the origin</a> of the context where
+                PaymentRequest was initialized.
+              </dd>
+              <dt>
+                <a data-lt="PaymentRequestEvent.methodData">methodData</a>
+              </dt>
+              <dd>
+                The result of executing the <a>MethodData Population
+                Algorithm</a>
+              </dd>

Let's keep `total`, `paymentRequestId`, `instrumentKey`, and `modifiers` in the `PaymentRequestEvent` for now.

```suggestion
              </dd>
              <dt>
                <a data-lt="PaymentRequestEvent.total">total</a>
              </dt>
              <dd>
                A <a>structured clone</a> of the total field on
                the <a>PaymentDetailsInit</a> from the corresponding
                <a>PaymentRequest</a>.
              </dd>
              <dt>
                <a data-lt="PaymentRequestEvent.paymentRequestId">paymentRequestId</a>
              </dt>
              <dd>
                The [[\details]].<a>id</a> from the <a>PaymentRequest</a>.
              </dd>
              <dt>
                <a data-lt="PaymentRequestEvent.instrumentKey">instrumentKey</a>
              </dt>
              <dd>
                The <a>instrumentKey</a> of the selected <a>PaymentInstrument</a>,
                or the empty string if none was selected.
              </dd>
              <dt>
                <a data-lt="PaymentRequestEvent.modifiers">modifiers</a>
              </dt>
              <dd>
                The result of executing the <a>Modifiers Population Algorithm</a>.
              </dd>
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/pull/327#pullrequestreview-165729456