- From: Marcos Cáceres <notifications@github.com>
- Date: Wed, 03 Oct 2018 08:53:14 -0700
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 3 October 2018 15:53:51 UTC
@rsolomakhin, for empty display item `label`, Chrome warns if it's empty but doesn't throw. Maybe we should do the same here? So, we can require at least one "valid" one. But console.warn if empty... I don't want to get into the game of checking, for instance: ```JS .retry({error: " "}); //single space .retry({error: " "}); .retry({error: "\n"}); .retry({error: "\t"}); ``` Alternatively, for all error label types, we trim and check if not empty string. Throw if empty. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-request/issues/792#issuecomment-426690225
Received on Wednesday, 3 October 2018 15:53:51 UTC