- From: Akansha <notifications@github.com>
- Date: Mon, 01 Oct 2018 07:09:34 -0700
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/payment-request/pull/789/c425921635@github.com>
> Thanks @akansha2608. Two little things: please be sure to retain the pull request template, as all tasks listed there need to be completed before we can merge. I've added it back above so we can work through it. Also, please use "@marcoscaceres" not @marcos-travel - as that's just an account I use while traveling. > Hi , thanks for the review , i will make sure from next time , its done totally by mistake. > So, to start, when you open "index.html" from your local file system, can you confirm there are no errors or warnings next to the "ReSpec" button at the top of right of the spec? > Hi @marcoscaceres , I checked the `index.html` on my local system , there is no errors or warnings near `ReSpec` button . Also attached screenshot for the same :) > Secondly, you need to check that `PayerErrorFields` doesn't appear on MDN (we might be lucky and it's not yet documented). But please confirm. If it's not documented, then we need to document it. > Yes we are lucky its not documented https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/PayerErrorFields, do we need to create another issue for the same? :smile: ![screenshot_2018-10-01 payment request api](https://user-images.githubusercontent.com/43577303/46293619-adc43380-c5b1-11e8-9402-58842f24f981.png) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-request/pull/789#issuecomment-425921635
Received on Monday, 1 October 2018 14:09:55 UTC