Re: [w3c/payment-request] Warn when errorFields don't match request[[options]] (#807)

domenic approved this pull request.

LGTM with question

> +                    "PaymentValidationErrors">payer</a>"]["<a data-link-for=
+                    "PayerErrors">email</a>"] is present.
+                  </li>
+                  <li>
+                    <var>request</var>.<a>[[\options]]</a>["<a data-link-for=
+                    "PaymentOptions">requestPayerPhone</a>"] is false, and
+                    <var>errorFields</var>["<a data-link-for=
+                    "PaymentValidationErrors">payer</a>"]["<a data-link-for=
+                    "PayerErrors">phone</a>"] is present.
+                  </li>
+                  <li>
+                    <var>request</var>.<a>[[\options]]</a>["<a data-link-for=
+                    "PaymentOptions">requestShipping</a>"] is false, and
+                    <var>errorFields</var>["<a data-link-for=
+                    "PaymentValidationErrors">shippingAddress</a>"] has any
+                    members present.

Shouldn't this just be "is present"? As written now this will not warn if you pass `shippingAddress: {}`

>              <ol>
-              <li>Reject <var>retryPromise</var> with <var>error</var>.
+              <li>Optionally, show a warning in the developer console if any of

FYI soon you and other specs will be able to link to a formal definition here, per https://github.com/whatwg/console/pull/151. No action for now though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/807#pullrequestreview-178891783