- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 21 Nov 2018 16:50:55 -0800
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 22 November 2018 00:51:21 UTC
domenic approved this pull request.
The duplication between "user aborts the payment request" and "abort the update" made this hard to review, but in the end I think the switch to that algorithm is fine. We should consider deduplicating those two algorithms though, if we can.
> @@ -887,9 +887,10 @@ <h2>
The <a>show()</a> method is called when a developer wants to begin
user interaction for the payment request. The <a>show()</a> method
returns a <a>Promise</a> that will be resolved when the <a>user
- accepts the payment request</a>. Some kind of user interface will
- be presented to the user to facilitate the payment request after
- the <a>show()</a> method returns.
+ accepts the payment request</a> or rejected if the <a>user aborts
+ the payment request</a>. Some kind of user interface will be
There's a lot of failure conditions, and listing only one of them might be a bit more confusing than helpful.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/810#pullrequestreview-177472633
Received on Thursday, 22 November 2018 00:51:21 UTC