- From: Peter Saint-Andre <notifications@github.com>
- Date: Wed, 09 May 2018 12:28:42 -0700
- To: w3c/payment-method-basic-card <payment-method-basic-card@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/payment-method-basic-card/pull/53/review/118872952@github.com>
stpeter commented on this pull request. > + The <dfn>steps for when a user changes payment method</dfn> are as + follows: + </p> + <ol> + <li>From the <a>supported cards</a> presented to the end-user, let + <var>card</var> be the <a>card</a> the user selected. + </li> + <li>Let <var>methodDetails</var> be a newly created + <a>BasicCardChangeDetails</a> dictionary. + </li> + <li>Set <var>methodDetails</var>["<a>type</a>"] to the + <a>BasicCardType</a> that represents <var>card</var>'s <a>type</a>. + </li> + <li>If the <var>card</var> is part of a <a>network</a>, set + <var>methodDetails</var>["<a>network</a>"] to the network identifier + that represents <var>card</var>'s <a>network</a> I concur with @mnoorenberghe. As @aestes noted when opening https://github.com/w3c/payment-request/issues/662, the `applepaypaymentmethodchanged` event "allows merchants to add additional display items based on the type of card selected by the user." I'm not sure what these display items are, but presumably they are not new items in the cart but actually payment modifiers (e.g., take $5 off if you pay with debit or 10% if you use your store card). If so, a `PaymentDetailsModifier` sequence can be provided in the initial payment request and the user agent can apply the modifiers locally if the user selects a card of a different type. Does the user agent _really_ need to fire an event off to the merchant here (e.g., so that the merchant can dynamically determine what modifiers will be applied)? That feels a bit far-fetched and not worth the privacy leak. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-method-basic-card/pull/53#discussion_r187150345
Received on Wednesday, 9 May 2018 19:29:06 UTC