- From: Matt N. <notifications@github.com>
- Date: Wed, 02 May 2018 13:37:33 -0700
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 2 May 2018 20:37:59 UTC
LGTM! Thanks for getting back to this so quickly! I only have two nits: * I'm not sure any UAs plan to expose the underlying `languageCode` so I'm not sure how useful an error message for it would be but I think it's fine to be consistent and support errors on all fields in the shipping address. * Tangent: I'd rather we fixed the misnomer of `addressLine` => `addressLines` everywhere rather than continuing to propagate it e.g. support both in the code already shipped in UAs treating the old name as an alias to the new name. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-request/issues/647#issuecomment-386112807
Received on Wednesday, 2 May 2018 20:37:59 UTC