- From: Matt N. <notifications@github.com>
- Date: Fri, 16 Mar 2018 05:11:04 +0000 (UTC)
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/payment-request/pull/690/review/104456411@github.com>
mnoorenberghe commented on this pull request. > + <li>If <var>details</var>["<a>regionCode</a>"] is present and not + the empty string: + <ol> + <li>Let <var>regionCode</var> be the result of <a>strip leading + and trailing ASCII whitespace</a> and <a data-cite= + "!INFRA#ascii-uppercase">ASCII uppercasing</a> + <var>details</var>["<a>regionCode</a>"]. + </li> + <li>If <var>regionCode</var> is not a valid [[!ISO3166-2]] + subdivision code, throw a <a>RangeError</a> exception. + </li> + <li>Set <var>address</var>.<a>[[\regionCode]]</a> to + <var>regionCode</var>. + </li> + </ol> + </li> We are already using libaddressinput (and I believe Chromium does too) so it would be great if we could also use that here instead of having two versions of similar data. Does ISO3166-2 only have one name per region? What about when there are multiple official languages? Consider CA-QC: is it "[Quebec](https://chromium-i18n.appspot.com/ssl-address/data/CA)" or "[Québec](https://chromium-i18n.appspot.com/ssl-address/data/CA--fr)" in ISO3166-2. libaddressinput provides both but without a clear way to know which one would match ISO3166-2. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-request/pull/690#discussion_r174999199
Received on Friday, 16 March 2018 05:11:44 UTC