Re: [w3c/payment-handler] Add CanMakePaymentEvent. (#170)

marcoscaceres commented on this pull request.



> @@ -368,7 +373,7 @@ <h2>
       interface PaymentManager {
         [SameObject] readonly attribute PaymentInstruments instruments;
         [Exposed=Window] static Promise&lt;PermissionState&gt; requestPermission();
-        attribute DOMString userHint;     
+        attribute DOMString userHint;

I'm scared of this... seems easy for developers to screw up and expose too much information, or in an ugly way "****". I'd rather the UA be in charge of masking instrument information.   

> @@ -847,6 +852,163 @@ <h2>
         </section>
       </section>
     </section>
+    <section id="canmakepayment">
+      <h2>
+        Can make payment
+      </h2>
+      <p>

We should add a `<div class="issue" data-number>` here describing the privacy concern. If we can dig up Adam's original comment, maybe we can copy/paste text from there. 

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/pull/170#pullrequestreview-79439327