Re: [w3c/payment-request] Add PaymentResponse.prototype.onpayerdetailchange (#724)

domenic approved this pull request.

LGTM!

> @@ -3981,23 +4021,19 @@ <h2>
           identifier</a> of the <a>payment handler</a> the user is interacting
           with:
         </p>
-        <ol class="algorithm">
+                <ol class="algorithm">

Whitspace change seems bad

> @@ -4049,6 +4081,88 @@ <h2>
           </li>
         </ol>
       </section>
+      <section>
+        <h2>
+          Payer detail changed algorithm
+        </h2>
+        <p>
+          The user agent MUST run the <dfn>payer detail changed algorithm</dfn>
+          when the user changes the <var>payer name</var>, or the <var>payer
+          email</var>, or the <var>payer phone</var> in the user interface:
+        </p>
+        <ol class="algorithm">
+          <li>Let <var>request</var> be the <a>PaymentRequest</a> object that
+          the user is interacting with.
+          </li>
+          <li>If <var>request</var>.<a>[[\response]]</a> is null, terminate
+          this algorithm.

"terminate this algorithm" -> "return"

> +              <li>Let <var>event</var> be the result of <a data-cite=
+              "!DOM#concept-event-create">creating an event</a> using
+              <a>PaymentRequestUpdateEvent</a>.
+              </li>
+              <li>Initialize <var>event</var>'s <code><a data-cite=
+              "!DOM#dom-event-type">type</a></code> attribute to
+              "<a>payerdetailchange</a>".
+              </li>
+              <li>
+                <a data-cite="!DOM#concept-event-dispatch">Dispatch</a>
+                <var>event</var> at <var>response</var>.
+              </li>
+              <li data-link-for="PaymentRequestUpdateEvent">If
+              <var>event</var>.<a>[[\waitForUpdate]]</a> is true, disable any
+              part of the user interface that could cause another update event
+              to be fired.

Is "another update event" appropriate here? Maybe "another change to the payer details"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/724#pullrequestreview-132987671