Re: [w3c/payment-request] Add PaymentResponse.prototype.onpayerdetailchange (#724)

domenic requested changes on this pull request.

A little hard to review due to the switched headings... let's get that fixed.

> @@ -3812,8 +3846,14 @@ <h2>
             <li>If <var>event</var>.<a>[[\waitForUpdate]]</a> is true, then <a>
               throw</a> an "<a>InvalidStateError</a>" <a>DOMException</a>.
             </li>
-            <li>Let <var>request</var> be the value of <var>event</var>'s
-            <a data-cite="DOM#event-target">target</a>.
+            <li>If <var>event</var>'s <a data-cite=
+            "DOM#event-target">target</a> is an instance of
+            <a>PaymentResponse</a>, let <var>request</var> be
+            <var>event</var>'s <a data-cite=
+            "DOM#event-target">target</a><a>[[\request]]</a>.

Missing dot

> @@ -3985,26 +4025,70 @@ <h2>
           <li>Let <var>request</var> be the <a>PaymentRequest</a> object that
           the user is interacting with.
           </li>
+          <li>If <var>request</var><a>[[\response]]</a> is null, terminate this

Missing dot

Use "return" instead of "terminate this algorithm"

> @@ -3985,26 +4025,70 @@ <h2>
           <li>Let <var>request</var> be the <a>PaymentRequest</a> object that
           the user is interacting with.
           </li>
+          <li>If <var>request</var><a>[[\response]]</a> is null, terminate this
+          algorithm.
+          </li>
+          <li>Let <var>response</var> be
+          <var>request</var><a>[[\response]]</a>.

Missing dot

Move this step up so that you can check if _response_ is null.

>                </li>
-              <li data-link-for="PaymentMethodChangeEvent">
-                <a>Fire an event</a> named "<a>paymentmethodchange</a>" at
-                <var>request</var> using <a>PaymentMethodChangeEvent</a>, with
-                its <a>methodName</a> attribute initialized to
-                <var>methodName</var>, and its <a>methodDetails</a> attribute
-                initialized to <var>methodDetails</var>.
+              <li>If <var>payer name</var> changed:
+                <ol>
+                  <li data-link-for="PaymentOptions">Assert:
+                  <var>request</var><a>[[\options]]</a>.<a>requestPayerName</a>

Search for `</var><a>[[`, so many missing dots...

> @@ -3985,26 +4025,70 @@ <h2>
           <li>Let <var>request</var> be the <a>PaymentRequest</a> object that

The algorithms seem to be switched; this is the payment details changed algorithm.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/724#pullrequestreview-132215409