- From: Blake Kaplan <notifications@github.com>
- Date: Wed, 20 Jun 2018 15:35:53 -0700
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 20 June 2018 22:36:15 UTC
Because `PaymentRequest.abort` returns a `Promise<void>`, it shouldn't be specified to throw exceptions. Instead, it should return rejected promises. Somewhat complicating this is that Safari does throw an exception (even though Firefox and Blink do not). This has an impact on web developers as an eager exception will stop their scripts and a rejected promise will not. The following tasks have been completed: * [x] Confirmed there are no ReSpec errors/warnings. * [ ] Added Web platform tests (link) * [ ] added MDN Docs (link) * [ ] added MDN [compat data](https://github.com/mdn/browser-compat-data) Implementation commitment: * [ ] Safari (link to issue) * [ ] Chrome (link to issue) * [ ] Firefox (link to issue) * [ ] Edge (public signal) Impact on Payment Handler spec? None. You can view, comment on, or merge this pull request online at: https://github.com/w3c/payment-request/pull/733 -- Commit Summary -- * Fix a small bug in `abort`'s error handling. -- File Changes -- M index.html (5) -- Patch Links -- https://github.com/w3c/payment-request/pull/733.patch https://github.com/w3c/payment-request/pull/733.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-request/pull/733
Received on Wednesday, 20 June 2018 22:36:15 UTC