Re: [w3c/payment-request] add paymentmethodchange event (#695)

domenic approved this pull request.

LGTM with nits

> +          <dfn>PaymentMethodChangeEvent</dfn> interface
+        </h2>
+        <pre class="idl">
+          [Constructor(DOMString type, optional PaymentMethodChangeEventInit eventInitDict), SecureContext, Exposed=Window]
+          interface PaymentMethodChangeEvent : PaymentRequestUpdateEvent {
+            readonly attribute DOMString methodName;
+            readonly attribute object? methodDetails;
+          };
+        </pre>
+        <section>
+          <h2>
+            <dfn>methodDetails</dfn> attribute
+          </h2>
+          <p data-link-for="PaymentMethodChangeEventInit">
+            When getting, returns the value it was initialized with. See
+            <a>methodDetails</a> member for more information.

Here and below, "member of PaymentMethodChangeEventInit" perhaps? Otherwise before you click on it it looks like it'll just link to itself.

> +          <li>
+            <a>Queue a task</a> on the <a>user interaction task source</a> to
+            run the following steps:
+            <ol>
+              <li>If the <var>request</var>.<a>[[\updating]]</a> is true, then
+              terminate this algorithm and take no further action. Only one
+              update may take place at a time. The <a>user agent</a> SHOULD
+              ensure that this never occurs.
+              </li>
+              <li>If the <var>request</var>.<a>[[\state]]</a> is not set to
+              "<a>interactive</a>", then terminate this algorithm and take no
+              further action. The <a>user agent</a> user interface SHOULD
+              ensure that this never occurs.
+              </li>
+              <li data-link-for="PaymentMethodChangeEvent">
+                <a>Fire an event</a> "<a>paymentmethodchange</a>" at

Fire an event **named**

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/695#pullrequestreview-128012853