Re: [w3c/payment-request] Support fine-grained errors for payment methods (#752)

domenic approved this pull request.

LGTM with nits editorially. Unsure on consensus status.

> @@ -3213,6 +3213,28 @@ <h2>
           <li>Set <var>response</var>.<a>[[\retryPromise]]</a> to
           <var>retryPromise</var>.
           </li>
+          <li data-link-for="PaymentValidationErrors">If
+          <var>errorFields</var>'s <a>paymentMethod</a> member was passed, and

"was passed" -> "is present"

> @@ -3213,6 +3213,28 @@ <h2>
           <li>Set <var>response</var>.<a>[[\retryPromise]]</a> to
           <var>retryPromise</var>.
           </li>
+          <li data-link-for="PaymentValidationErrors">If
+          <var>errorFields</var>'s <a>paymentMethod</a> member was passed, and
+          if required by the specification that defines <var>response</var>'s
+          <a>payment method</a>, then <a data-cite=
+          "!WEBIDL#dfn-convert-ecmascript-to-idl-value">convert</a>
+          <var>errorFields</var> <a>paymentMethod</a> to an IDL value.
+          Otherwise, <a data-cite=

Unsure whether this buys anything, versus just ignoring it. Maybe it's useful for web-based payment handlers??

> @@ -3213,6 +3213,28 @@ <h2>
           <li>Set <var>response</var>.<a>[[\retryPromise]]</a> to
           <var>retryPromise</var>.
           </li>
+          <li data-link-for="PaymentValidationErrors">If
+          <var>errorFields</var>'s <a>paymentMethod</a> member was passed, and
+          if required by the specification that defines <var>response</var>'s
+          <a>payment method</a>, then <a data-cite=
+          "!WEBIDL#dfn-convert-ecmascript-to-idl-value">convert</a>
+          <var>errorFields</var> <a>paymentMethod</a> to an IDL value.

Maybe "to an IDL value of the type specified there" or similar?

> @@ -3273,6 +3296,14 @@ <h3>
               Represents validation errors with the <a>PaymentResponse</a>'s
               <a>shippingAddress</a>.
             </dd>
+            <dt>
+              <dfn>paymentMethod</dfn> member
+            </dt>
+            <dd>
+              A payment method specific error. See, for example,

Singular -> plural?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/752#pullrequestreview-135583915