Re: [w3c/payment-request] Add localization hint for payment sheet (#656)

domenic approved this pull request.

LGTM with a nit and a suggestion for expansion. Although, just using the language of the body element might suffice for #650 without any new APIs...

> @@ -935,8 +951,11 @@ <h2>
           <li>
             <p>
               Otherwise, present a user interface to allow the user to interact
-              with the <var>handlers</var>. The user agent SHOULD prioritize
-              the preference of the user when presenting payment methods.
+              with the <var>handlers</var>. Optionally, if
+              <var>request</var>.<a>[[\uiLang]]</a> is not null, localize the
+              user interface to match, as closely as possible, the language of
+              <a>[[\uiLang]]</a>. The user agent SHOULD prioritize the

I think you should paragraph break before the last sentence as now it's somewhat disconnected from the rest.

> @@ -935,8 +951,11 @@ <h2>
           <li>
             <p>
               Otherwise, present a user interface to allow the user to interact
-              with the <var>handlers</var>. The user agent SHOULD prioritize
-              the preference of the user when presenting payment methods.
+              with the <var>handlers</var>. Optionally, if
+              <var>request</var>.<a>[[\uiLang]]</a> is not null, localize the
+              user interface to match, as closely as possible, the language of
+              <a>[[\uiLang]]</a>. The user agent SHOULD prioritize the

Should we state more about what to do if [[uiLang]] is null? For example using the [language](https://html.spec.whatwg.org/#language) of [the body element](https://html.spec.whatwg.org/#the-body-element-2)?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/656#pullrequestreview-90245136