Re: [w3c/payment-request] fix: default methodName to empty string (#771) from Domenic Denicola on 2018-08-30 (public-webpayments-specs@w3.org from August 2018)

From: Domenic Denicola <notifications@github.com>
Date: Thu, 30 Aug 2018 15:03:24 +0000 (UTC)
To: w3c/payment-request <payment-request@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <w3c/payment-request/pull/771/review/151040417@github.com>

domenic approved this pull request.

LGTM, but might also want to add a `= null` for methodDetails. I don't think it has any normative effect, but it seems like the trend is to have defaults for all event-init dictionaries?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/771#pullrequestreview-151040417

Received on Thursday, 30 August 2018 15:03:47 UTC