Re: [w3c/payment-request] Add support for merchant validation (#751)

domenic requested changes on this pull request.

Only a couple more minor things

> +        <h2>
+          <dfn>MerchantValidationEvent</dfn> interface
+        </h2>
+        <pre class="idl">
+          [Constructor(DOMString type, optional MerchantValidationEventInit eventInitDict),
+          SecureContext, Exposed=Window]
+          interface MerchantValidationEvent : Event {
+            readonly attribute USVString validationURL;
+            void complete(Promise&lt;any&gt; merchantSessionPromise);
+          };
+        </pre>
+        <section>
+          <h3>
+            <dfn data-lt=
+            "MerchantValidationEvent.MerchantValidationEvent()"><code>MerchantValidationEvent</code>
+            Constructor</dfn>

Lowercase "c"

> +          SecureContext, Exposed=Window]
+          interface MerchantValidationEvent : Event {
+            readonly attribute USVString validationURL;
+            void complete(Promise&lt;any&gt; merchantSessionPromise);
+          };
+        </pre>
+        <section>
+          <h3>
+            <dfn data-lt=
+            "MerchantValidationEvent.MerchantValidationEvent()"><code>MerchantValidationEvent</code>
+            Constructor</dfn>
+          </h3>
+          <p data-tests=
+          "MerchantValidationEvent/constructor.https.html, MerchantValidationEvent/constructor.http.html">
+            The <dfn>event constructing steps for a
+            <code>MerchantValidationEvent</code></dfn>, which take a

Needs to link to "event constructing steps" in DOM, not define a new set of steps.

> +            "!html/multipage/webappapis.html#relevant-settings-object">relevant
+            settings object</a>’s <a data-cite=
+            "!html/multipage/webappapis.html#api-base-url">API base URL</a>.
+            </li>
+            <li>Let <var>input</var> be the empty string.
+            </li>
+            <li>If <var>eventInitDict</var> was passed, set <var>input</var> to
+            the value of <var>eventInitDict</var>["<a>validationURL</a>"].
+            </li>
+            <li data-link-for="MerchantValidationEventInit">Let
+            <var>validationURL</var> be the result of <a data-cite=
+            "!url#concept-url-parser">URL parsing</a> <var>input</var> and
+            <var>base</var>.
+            </li>
+            <li>If <var>validationURL</var> is failure, throw a
+            <a>TypeError</a>.

Needs to initialize _event_'s `validationURL` attribute to _validationURL_

> +            </li>
+            <li>If <var>eventInitDict</var> was passed, set <var>input</var> to
+            the value of <var>eventInitDict</var>["<a>validationURL</a>"].
+            </li>
+            <li data-link-for="MerchantValidationEventInit">Let
+            <var>validationURL</var> be the result of <a data-cite=
+            "!url#concept-url-parser">URL parsing</a> <var>input</var> and
+            <var>base</var>.
+            </li>
+            <li>If <var>validationURL</var> is failure, throw a
+            <a>TypeError</a>.
+            </li>
+            <li>Initialize <var>event</var>.<a data-lt=
+            "mechvalidation.waitForUpdate">[[\waitForUpdate]]</a> to false.
+            </li>
+            <li>Return <var>event</var>.

No need to return anything from these steps.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/751#pullrequestreview-150194465