- From: Marcos Cáceres <notifications@github.com>
- Date: Thu, 16 Aug 2018 19:58:07 -0700
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 17 August 2018 02:58:28 UTC
marcoscaceres commented on this pull request.
> @@ -3881,9 +3904,16 @@ <h2>
</li>
<li>Set <var>event</var>.<a>[[\waitForUpdate]]</a> to true.
</li>
+ <li>Let <var>identifer</var> be undefined.
@rsolomakhin, so I totally agree: problem is we have `methodName` attributes on both `PaymentResponse` and `PaymentMethodChangeEvent`, both standing for PMI. Changing this one to be `pmi` or `paymentMethodIdentifier` would make this one the odd one out 😢
Although `methodName` is a terrible name, I'd prefer we stay consistent. Is that ok?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/749#discussion_r210794221
Received on Friday, 17 August 2018 02:58:28 UTC