Re: [w3c/payment-handler] Incorporate the canMakePayment algorithm of the payment method good practices doc. (#313)

ianbjacobs commented on this pull request.

Thank you, Rouslan. Some minor comments inline.

> @@ -1047,17 +1047,20 @@ <h2>
               </li>
             </ol>
           </li>
-          <li>Otherwise, fire the <a>CanMakePaymentEvent</a> in the payment
-          handler and return the result.
+          <li>Otherwise, if the <a>URL-based payment method identifier</a> and
+          payment handler share the same <a data-cite=

Is "payment handler" enough, or do you want to say something like "scope URL of the payment handler"?

> @@ -1047,17 +1047,20 @@ <h2>
               </li>
             </ol>
           </li>
-          <li>Otherwise, fire the <a>CanMakePaymentEvent</a> in the payment
-          handler and return the result.
+          <li>Otherwise, if the <a>URL-based payment method identifier</a> and
+          payment handler share the same <a data-cite=
+          "!HTML#origin">origin</a>, fire the <a>CanMakePaymentEvent</a> in the
+          payment handler and return the result.
+          </li>
+          <li>Otherwise, if <code>"supported_origins"</code> value in the
+          payment method manifest includes the <a data-cite=
+          "HTML#origin">origin</a> of the payment handler, fire the

Same observation here: "of the scope URL of the payment handler"?

> @@ -2029,7 +2032,7 @@ <h2>
         </h2>
         <ul>
           <li>The party responsible for a payment method authorizes payment
-          apps through a [[payment-method-manifest]]. See the <a>Handling a
+          apps through a payment-method-manifest. See the <a>Handling a

Was this edit intentional? I think a reference to that spec here makes sense.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/pull/313#pullrequestreview-147034119