Re: [w3c/payment-request] Add ability to request billing address (#749)

rsolomakhin approved this pull request.

Overall looks good. I have a question and a nitpick suggestion.

> @@ -3881,9 +3904,16 @@ <h2>
             </li>
             <li>Set <var>event</var>.<a>[[\waitForUpdate]]</a> to true.
             </li>
+            <li>Let <var>identifer</var> be undefined.

@marcoscaceres I would prefer to name this `methodIdentifier` to avoid confusion with the Payment Request identifier. `paymentMethodIdentifier` and `pmi` would also be OK.

> +              <li data-link-for="PaymentDetailsUpdate">If the
+              <a>paymentMethodErrors</a> member is present and
+              <var>identifier</var> is not undefined:
+                <ol>
+                  <li>If required by the specification that defines the
+                  <var>identifer</var>, then <a data-cite=
+                  "!WEBIDL#dfn-convert-ecmascript-to-idl-value">convert</a> <a>
+                    paymentMethodErrors</a> to an IDL value. Otherwise,
+                    <a data-cite=
+                    "!WEBIDL#dfn-convert-ecmascript-to-idl-value">convert</a>
+                    <a>paymentMethodErrors</a> to <a data-cite=
+                    "!WEBIDL#idl-object">object</a>.
+                  </li>
+                  <li>If conversion results in a <a data-cite=
+                  "!WEBIDL#dfn-exception">exception</a> <var>error</var>,
+                  <a>abort the update</a> with <var>error</var>.

@marcoscaceres Does "abort the update" result in abort of payment (i.e., the promise returned byu PaymentRequest.show() is rejected)?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/749#pullrequestreview-146892478