Re: [w3c/payment-handler] SW registration code unclear/incorrect (#223) from Jinho Bang on 2017-11-20 (public-webpayments-specs@w3.org from November 2017)

From: Jinho Bang <notifications@github.com>
Date: Mon, 20 Nov 2017 14:40:45 +0000 (UTC)
To: w3c/payment-handler <payment-handler@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <w3c/payment-handler/issues/223/345714913@github.com>

Absolutely.

As far as I remember, that part was in the spec, but it seems to be removed now[1].
When I implemented PaymentHandler API in Chromium/Blink, I did make instrument.set() be only allowed in the active worker according to the spec[2].

I guess that it was just a mistake that it was removed. When we moved from PaymentApp API to PaymentHandler API, there are much changes. So, it's just missed. (I think)

@ianbjacobs, Is there any special reason why the spec text was removed?
If no reasons, we can restore the spec text simply :)

[1] https://github.com/w3c/payment-handler/pull/107/files#diff-eacf331f0ffc35d4b482f1d15a887d3bL828
[2] https://codereview.chromium.org/2790013002 (PaymentInstruments.cpp, 38 line)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/issues/223#issuecomment-345714913

Received on Monday, 20 November 2017 14:41:16 UTC