Re: [w3c/payment-request] Editorial: define create a PaymentAddress algo (#644)

domenic requested changes on this pull request.

A few nits that would be good to fix.

> +        <ol data-link-for="PaymentAddress">
+          <li>Let <var>address</var> be a new instance of
+          <a>PaymentAddress</a>.
+          </li>
+          <li>Set <var>address</var>.<a>[[\addressLine]]</a> to the result of
+          splitting the user-provided address line into a <a data-cite=
+          "!WEBIDL#dfn-frozen-array-type">frozen array</a>. If none was
+          provided, set it to the empty <a data-cite=
+          "!WEBIDL#dfn-frozen-array-type">frozen array</a>.
+            <aside class="note">
+              How to split an address line is locale dependent and beyond the
+              scope of this specification.
+            </aside>
+          </li>
+          <li>Set <var>address</var>.<a>[[\country]]</a> to the user-provided
+          <a>country</a> as an upper case [[!ISO3166]] alpha-2 code, or to the

Should not be `<a>country</a>` as that links to a dictionary member.

> @@ -1910,6 +1910,80 @@
       </pre>
       <section>
         <h2>
+          Creating a <code>PaymentAddress</code>
+        </h2>
+        <p>
+          The steps to <dfn>create a payment address</dfn> are given by the
+          following algorithm.

It'd be nice to mention in this sentence something like "**create a payment address** from user-provided input" as otherwise you get a bit taken aback realizing that this algorithm isn't a general creation algorithm, it's specifically about user input.

> -              provided.
-              </li>
-              <li>Set <var>address</var>.<a>[[\recipient]]</a> to the
-              user-provided recipient of the transaction, or to the empty
-              string if none was provided.
-              </li>
-              <li>Set <var>address</var>.<a>[[\region]]</a> to the
-              user-provided region, or to the empty string if none was
-              provided.
-              </li>
-              <li>Set <var>address</var>.<a>[[\sortingCode]]</a> to the
-              user-provided sorting code, or to the empty string if none was
-              provided.
+            <ol>
+              <li>Let <var>address</var> be the result of running the steps to
+              <a>create a payment address</a>

Missing a period.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/644#pullrequestreview-74314607