- From: Jinho Bang <notifications@github.com>
- Date: Tue, 30 May 2017 17:58:31 -0700
- To: w3c/payment-handler <payment-handler@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/payment-handler/pull/162/review/41111585@github.com>
romandev commented on this pull request. Thank you for review. I addressed your comments :) But I have a question. The Tidy makes another change which is not related this change's context. Is it no problem? > @@ -1428,11 +1428,29 @@ permission either at installation or when the payment app is first invoked. </p> - <p class="issue" title="DOM Events compatibility" data-number="119"> - For DOM events compatibility, need to add a constructor, and the - members of the corresponding dictionary need to match the attributes - of the event. - </p> + <section data-dfn-for="PaymentRequestEventInit"> + <h2> + <dfn>PaymentRequestEventInit</dfn> dictionary + </h2> + <p> Done. > @@ -1428,11 +1428,29 @@ permission either at installation or when the payment app is first invoked. </p> - <p class="issue" title="DOM Events compatibility" data-number="119"> - For DOM events compatibility, need to add a constructor, and the - members of the corresponding dictionary need to match the attributes - of the event. - </p> + <section data-dfn-for="PaymentRequestEventInit"> + <h2> + <dfn>PaymentRequestEventInit</dfn> dictionary + </h2> + <p> + The <dfn>topLevelOrigin</dfn>, <dfn>paymentRequestOrigin</dfn>, + <dfn>paymentRequestId</dfn>, <dfn> methodData</dfn>, I did but it contains another changes which not related this change. Is it no problem? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-handler/pull/162#pullrequestreview-41111585
Received on Wednesday, 31 May 2017 00:59:07 UTC