Re: [w3c/payment-handler] Add a constructor of PaymentRequestEvent and PaymentRequestEventInit. (#162)

romandev commented on this pull request.

Thank you for review. I addressed your comments :)
But I have a question. The Tidy makes another change which is not related this change's context.
Is it no problem?

> @@ -1428,11 +1428,29 @@
           permission either at installation or when the payment app is first
           invoked.
         </p>
-        <p class="issue" title="DOM Events compatibility" data-number="119">
-          For DOM events compatibility, need to add a constructor, and the
-          members of the corresponding dictionary need to match the attributes
-          of the event.
-        </p>
+        <section data-dfn-for="PaymentRequestEventInit">
+          <h2>
+            <dfn>PaymentRequestEventInit</dfn> dictionary
+          </h2>
+          <p>

Done.

> @@ -1428,11 +1428,29 @@
           permission either at installation or when the payment app is first
           invoked.
         </p>
-        <p class="issue" title="DOM Events compatibility" data-number="119">
-          For DOM events compatibility, need to add a constructor, and the
-          members of the corresponding dictionary need to match the attributes
-          of the event.
-        </p>
+        <section data-dfn-for="PaymentRequestEventInit">
+          <h2>
+            <dfn>PaymentRequestEventInit</dfn> dictionary
+          </h2>
+          <p>
+            The <dfn>topLevelOrigin</dfn>, <dfn>paymentRequestOrigin</dfn>,
+            <dfn>paymentRequestId</dfn>, <dfn> methodData</dfn>,

I did but it contains another changes which not related this change. Is it no problem?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/pull/162#pullrequestreview-41111585

Received on Wednesday, 31 May 2017 00:59:07 UTC