Re: [w3c/payment-handler] Add a constructor of PaymentRequestEvent and PaymentRequestEventInit. (#162)

romandev commented on this pull request.

Thank you for review!

> @@ -1314,6 +1314,16 @@
           Promise<WindowClient> openWindow(USVString url);
           void respondWith(Promise<PaymentAppResponse>appResponse);
         };
+
+        dictionary PaymentRequestEventInit : ExtendableEventInit {
+          DOMString topLevelOrigin;

Done.

> @@ -1314,6 +1314,16 @@
           Promise<WindowClient> openWindow(USVString url);
           void respondWith(Promise<PaymentAppResponse>appResponse);
         };
+
+        dictionary PaymentRequestEventInit : ExtendableEventInit {
+          DOMString topLevelOrigin;
+          DOMString paymentRequestOrigin;

Done.

> @@ -1314,6 +1314,16 @@
           Promise<WindowClient> openWindow(USVString url);
           void respondWith(Promise<PaymentAppResponse>appResponse);
         };
+
+        dictionary PaymentRequestEventInit : ExtendableEventInit {
+          DOMString topLevelOrigin;
+          DOMString paymentRequestOrigin;
+          DOMString paymentRequestId;
+          sequence<PaymentMethodData> methodData;
+          PaymentItem total;
+          sequence<PaymentDetailsModifier> modifiers;
+          DOMString instrumentKey;
+        };

I tried to find a way to define the things in PaymentRequestEventInit as sharing a definition with PaymentRequestEvent but I couldn't.
I read WebIDL Guide[1] in respec's wiki but I couldn't find solution there.

So, I added "no-link-warnings" to the class attr of `<pre class="idl">` to silence the warnings according to your comment in [2].

If  you have another idea, please let me know.

Thank you for review!

[1] https://github.com/w3c/respec/wiki/WebIDL-Guide
[2] https://github.com/w3c/respec/issues/1027

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/pull/162#pullrequestreview-40674331