Re: [w3c/payment-handler] Add a constructor of PaymentRequestEvent and PaymentRequestEventInit. (#162)

marcoscaceres requested changes on this pull request.

Looking good... 

> @@ -1314,6 +1314,16 @@
           Promise<WindowClient> openWindow(USVString url);
           void respondWith(Promise<PaymentAppResponse>appResponse);
         };
+
+        dictionary PaymentRequestEventInit : ExtendableEventInit {
+          DOMString topLevelOrigin;

Here you want: USVString (because it's a URL)

> @@ -1314,6 +1314,16 @@
           Promise<WindowClient> openWindow(USVString url);
           void respondWith(Promise<PaymentAppResponse>appResponse);
         };
+
+        dictionary PaymentRequestEventInit : ExtendableEventInit {
+          DOMString topLevelOrigin;
+          DOMString paymentRequestOrigin;

Same here as above.

> @@ -1314,6 +1314,16 @@
           Promise<WindowClient> openWindow(USVString url);
           void respondWith(Promise<PaymentAppResponse>appResponse);
         };
+
+        dictionary PaymentRequestEventInit : ExtendableEventInit {
+          DOMString topLevelOrigin;
+          DOMString paymentRequestOrigin;
+          DOMString paymentRequestId;
+          sequence<PaymentMethodData> methodData;
+          PaymentItem total;
+          sequence<PaymentDetailsModifier> modifiers;
+          DOMString instrumentKey;
+        };

You will need to define the things in PaymentRequestEventInit as sharing a definition with PaymentRequestEvent, or ReSpec will probably get upset. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-handler/pull/162#pullrequestreview-39953932