- From: Marcos Cáceres <notifications@github.com>
- Date: Tue, 09 May 2017 00:46:02 -0700
- To: w3c/browser-payment-api <browser-payment-api@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/browser-payment-api/pull/527/review/36958547@github.com>
marcoscaceres requested changes on this pull request. Some of these need to be changed to singular: either "a developer" or "the developer", where it makes sense. > @@ -1867,16 +1867,16 @@ </p> <p> After the payment request has been accepted and the - <a>PaymentResponse</a> returned to the page but before the page calls - <a>complete()</a> the payment request user interface remains in a - pending state. At this point the user interface ought not offer a + <a>PaymentResponse</a> returned to developers but before developers this one should probably be phrased in terms of the caller or script. > cancel command because acceptance of the payment request has been - returned. However, if something goes wrong and the page never calls + returned. However, if something goes wrong and developers never call this one needs to be singular. > @@ -215,13 +215,13 @@ }; </pre> <p> - A web page creates a <a>PaymentRequest</a> to make a payment request. + Developers create a <a>PaymentRequest</a> to make a payment request. Singular here. > </li> <li>For each <var>paymentMethod</var> of <var>methodData</var>: <ol> <li>If the length of the <var>paymentMethod</var>.<a>supportedMethods</a> sequence is zero, then <a>throw</a> a <a>TypeError</a>, optionally - informing the developer that each <a>payment method</a> needs + informing developers that each <a>payment method</a> needs singular here. Check the others. Might make more sense as just "the developer" > @@ -324,7 +324,7 @@ </pre> <p> The <var>options</var> object contains information about what - options the web page wishes to use from the payment request system. + options developers wish to use from the payment request system. Maybe: "...information the developer needs from the end-user to perform the payment (e.g., the person's name and shipping address)." > @@ -360,15 +360,15 @@ <li>Process payment methods: <ol data-link-for="PaymentMethodData"> <li>If the length of the <var>methodData</var> sequence is zero, - then <a>throw</a> a <a>TypeError</a>, optionally informing the - developer that at least one <a>payment method</a> is required. + then <a>throw</a> a <a>TypeError</a>, optionally informing + developers that at least one <a>payment method</a> is required. singular here. > </li> <li>If the first character of <var>details</var>.<a>total</a>.<a data-lt= "PaymentItem.amount">amount</a>.<a data-lt= "PaymentCurrencyAmount.value">value</a> is U+002D HYPHEN-MINUS, - then <a>throw</a> a <a>TypeError</a>, optionally informing the - developer that the total can't be negative. + then <a>throw</a> a <a>TypeError</a>, optionally informing + developers that the total can't be negative. same here.. > @@ -394,14 +394,14 @@ "PaymentItem.amount">amount</a>.<a data-lt= "PaymentCurrencyAmount.value">value</a> is not a <a>valid decimal monetary value</a>, then <a>throw</a> a <a>TypeError</a>; - optionally informing the developer that the value is invalid. + optionally informing developers that the value is invalid. same... > @@ -597,7 +597,7 @@ </h2> <div class="note"> <p> - The <a>show()</a> method is called when the page wants to begin + The <a>show()</a> method is called when developers want to begin "a developer" -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/browser-payment-api/pull/527#pullrequestreview-36958547
Received on Tuesday, 9 May 2017 07:46:36 UTC