> Is the behavior for the error member correct? Or should the presence of that lead to the UA ignoring everything else and just showing the error? Hmm... good question... it feels like you could do both: update things, but also show an error as needed. Not sure what implementations are doing today. > The constructor does not allow negative modifier totals, but updateWith() does. Is that correct? `updateWith()` also should forbid a negative total. > Maybe I can refactor the constructor and updateWith() to share some logic here? If you feel it's worth it. I'd be ok with some minor duplication, but up to you. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/browser-payment-api/pull/451#issuecomment-285214698
Received on Thursday, 9 March 2017 00:25:25 UTC