Re: [w3c/browser-payment-api] editorial: attr/method intros are notes (closes #379) (#438)

domenic approved this pull request.

Some nits to fix, but this is quite a bit nicer, yay.

> @@ -121,7 +121,7 @@
         authorizing as necessary across the flow.
       </p>
       <p>
-        The details of how to fulfill a payment request for a given <a>payment
+        The details of how to fulfil a payment request for a given <a>payment

The original word was correct here

>          </p>
-        <p>
-          <dfn>onshippingoptionchange</dfn> is an <code>EventHandler</code> for
-          an <code>Event</code> named <code>shippingoptionchange</code>.
+      </section>
+      <section data-dfn-for="PaymentRequest" data-link-for="PaymentRequest">
+        <h2>
+          <dfn>onshippingoptionchange</dfn> attribute
+        </h2>
+        <p class="note">

This should not be a note, to be consistent

> @@ -1918,6 +1974,12 @@
           <h2>
             <dfn data-lt="updateWith(detailsPromise)">updateWith()</dfn> method
           </h2>
+          <p class="note">
+            If the web page wishes to update the payment request then it can
+            call <a>updateWith()</a> and provide a promise that will resolve
+            with a <a>PaymentDetailsUpdate</a> dictionary containing changed

Maybe point out that you don't have to provide a promise. E.g. "provide a PaymentDetailsUpdate dictionary, or a promise for one, containing..."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/browser-payment-api/pull/438#pullrequestreview-25582855