Re: [w3c/browser-payment-api] feat: put request id in details dictionary (#426)

domenic requested changes on this pull request.

Bad rebase but overall looking good to me.

> @@ -583,6 +595,16 @@
       </section>
       <section data-dfn-for="PaymentRequest" data-link-for="PaymentRequest">
         <h2>
+          <dfn>id</dfn> attribute
+        </h2>
+        <p>
+          When getting, the <a>id</a> attribute returns this
+          <a>PaymentRequest</a> <a>[[\details]]</a>.<a data-lt=

Nit: missing `'s` after PaymentRequest

> @@ -1035,7 +1057,9 @@
         <dfn>PaymentDetailsBase</dfn> dictionary
       </h2>
       <pre class="idl">
-        dictionary PaymentDetailsBase {
+        dictionary PaymentDetails {

Rebasing seems to have gone bad here.

> @@ -1047,6 +1071,29 @@
       </p>
       <dl>
         <dt>
+          <dfn>id</dfn>
+        </dt>
+        <dd>
+          <a>id</a> is a free-form identifier for this payment request.
+          <p class="note">
+            If an <a>id</a> member is not present, then the <a>user agent</a>
+            will generate a unique identifier for the payment request during
+            <a data-lt="PaymentRequest.PaymentRequest()">construction</a>.
+          </p>
+        </dd>
+        <dt>
+          <dfn>total</dfn>

and here

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/browser-payment-api/pull/426#pullrequestreview-25367867