Re: [w3c/browser-payment-api] Editorial: refer to methods with parentheses (closes #378) (#398)

domenic commented on this pull request.

Oh, I caught one more missing one. updateWith!

I guess with that in mind we now have competing conventions of using `<var>` (updateWith) vs. `<code>` (complete) for argument names, inside the method algorithms. Either seems fine but we should stick with one...

> +    <section data-dfn-for="PaymentComplete" data-link-for="PaymentComplete">
+      <h2><dfn>PaymentComplete</dfn> enum</h2>
+      <pre class="idl">
+        enum PaymentComplete {
+          "fail",
+          "success",
+          "unknown",
+        };
+      </pre>
+      <dl>
+        <dt>
+          "<dfn>fail</dfn>"
+        </dt>
+        <dd>
+          Indicates that processing of the payment failed. The <a>user
+          agent</a> MAY display UI indicating failure.

It's a bit weird that these normative processing model requirements are given in the definition of the enum, instead of in the algorithm that processes it, but that's a separate issue.

> @@ -1492,13 +1490,44 @@ <h2 id="state-transitions" class="informative">
         </dd>
       </dl>
     </section>
+    <section data-dfn-for="PaymentComplete" data-link-for="PaymentComplete">
+      <h2><dfn>PaymentComplete</dfn> enum</h2>

Maybe add the missing "enum" to the PaymentShippingType header while you're here

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/browser-payment-api/pull/398#pullrequestreview-17356805