Re: [w3c/browser-payment-api] fix: delegate total and error member checks to WebIDL (#425)

bentian commented on this pull request.



> @@ -1102,21 +1086,68 @@
           modifiers for particular payment method identifiers. For example, it
           allows you to adjust the total amount based on payment method.
         </dd>
+      </dl>
+    </section>
+    <section data-dfn-for="PaymentDetailsInit" data-link-for=
+    "PaymentDetailsInit">
+      <h2>
+        <dfn>PaymentDetailsInit</dfn> dictionary
+      </h2>
+      <pre class="idl">
+        dictionary PaymentDetailsInit : PaymentDetailsBase {
+          required PaymentItem total;

Seems WebIDL should be revised, per [section Dictionaries, WebIDL level 1](https://www.w3.org/TR/WebIDL-1/#idl-dictionaries):
> The identifier of a dictionary member MUST NOT be the same as that of another dictionary member defined on the dictionary or on that dictionary’s inherited dictionaries. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/browser-payment-api/pull/425#discussion_r102661969

Received on Thursday, 23 February 2017 08:38:16 UTC