- From: Jinho Bang <notifications@github.com>
- Date: Wed, 30 Aug 2017 09:49:07 -0700
- To: w3c/payment-handler <payment-handler@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 30 August 2017 16:49:49 UTC
romandev commented on this pull request. > @@ -529,6 +529,7 @@ interface PaymentManager { [SameObject] readonly attribute PaymentInstruments instruments; [Exposed=Window] static Promise<PermissionState> requestPermission(); + DOMString userHint; I think this should be attribute because this is not dictionary type. ```attribute DOMString userHint``` Also, if you don't mind, isn't it better to move this attribute to PaymentInstruments? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-handler/pull/206#pullrequestreview-59622037
Received on Wednesday, 30 August 2017 16:49:49 UTC