- From: Dave Longley <notifications@github.com>
- Date: Fri, 25 Aug 2017 20:43:47 +0000 (UTC)
- To: w3c/payment-handler <payment-handler@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 25 August 2017 20:44:10 UTC
@rsolomakhin, I think the approach of adding an `insertKeyBefore` parameter is potentially ok, though talking about the PaymentInstruments interface this like its an ordered Map is a bit strange to me. I can see now how it nearly maps to one, but I didn't implement this that way in the polyfill, I used a row for each PaymentInstrument handlerUrl + key + details in IndexedDB. I'm thinking about this being edited both in service workers (via push notifications) and in front of the user on a website, potentially concurrently. If I strip all of that away and think of it as a single Map sitting in one browser context ...that results in a totally different perspective. I can see now how you can think of this as a single Map instance that is built up all at once or cleared and rebuilt entirely at once. I wasn't thinking of it happening like that at all -- but much more piecemeal. The flows for making changes to this container are potentially very different in my mind. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-handler/pull/206#issuecomment-325029991
Received on Friday, 25 August 2017 20:44:10 UTC