- From: Adrian Hope-Bailie <notifications@github.com>
- Date: Mon, 07 Aug 2017 13:46:50 +0000 (UTC)
- To: w3c/payment-request <payment-request@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/payment-request/pull/574/review/54657890@github.com>
adrianhopebailie commented on this pull request. > @@ -841,9 +841,9 @@ </li> <li>Determine which <a>payment handlers</a> support <var>identifier</var>. For each resulting payment handler, if - payment method specific capabilities supplied by the payment - handler match those provided by <var>data</var>, the payment - handler matches. + <var>data</var> contains filters that exclude the payment @ianbjacobs - I'm still not clear what "capabilities provided by data" means. It doesn't make sense to me. The spec should be talking about what is in the `data` as "filtering" the available payment handlers (even if not called "filters" explicitly). How about: "Determine which payment handlers support identifier. Filter the set of matching payment handlers further by comparing the capabilities of each payment handler with the content of `data`. For each payment handler; if `data` implies that payment method specific capabilities are required and these are not provided, the payment handler does not match, otherwise the payment handler matches." Bare in mind that we are exploring a `canMakePayment()` lambda on handlers so the assumption is that this would be called here for web-based handlers BUT we don't (can't) talk about that explicitly and create a dependency on Payment Handler so we need to have something that implies that (or similar behavior) but is generic enough to not introduce the dependency and also works for other types of handler like the built in handler for basic card and platform native handlers too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-request/pull/574#discussion_r131658264
Received on Monday, 7 August 2017 13:47:30 UTC